-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: use native-tls in ureq requests to trust system TLS certs #2988
Conversation
Great, going to build and test to see if this works with subtrace enabled now! Should we also up our subtrace version in this pr? |
Nope, everything should work with the old version of subtrace. You can remove the |
6abbe9d
to
ab1d5ee
Compare
(forgot a couple of |
@adtac In this project we use both |
|
a1044fa
to
096ba67
Compare
cherry picked, rebased onto latest main |
096ba67
to
59036e8
Compare
fixed the unused |
Just built a docker image @ Also note that the default run command is not subtrace. You will need set your run command to this. trieve/helm/templates/server-deployment.yaml Lines 36 to 46 in a225fe3
|
434524e
to
f7802e4
Compare
f7802e4
to
d9172d7
Compare
I believe d9172d7 will fix https://github.com/devflowinc/trieve/actions/runs/12424254684/job/34689358734?pr=2988 (also rebased onto latest main) |
Yes, it should can you add that into this PR. Testing environment works with Subtrace!!! |
46351de
to
573c46b
Compare
573c46b
to
f4c275b
Compare
@skeptrunedev @cdxker
This PR makes
ureq
use thenative-tls
feature so that the distro-supplied TLS certificates are trusted.The following change captures the gist of this PR:
I believe all instances of
ureq::get
,ureq::post
, etc. have been changed, but if there's anything missing / if this PR doesn't match your code style, feel free to close it and incorporate the changes in a new PR :)