Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sk/remove back to dashboard #2977

Merged
merged 1 commit into from
Dec 19, 2024
Merged

sk/remove back to dashboard #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/search-component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"import": "./dist/vanilla/index.js"
}
},
"version": "0.2.30",
"version": "0.2.31",
"license": "MIT",
"homepage": "https://github.com/devflowinc/trieve/tree/main/clients/search-component",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion clients/ts-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"files": [
"dist"
],
"version": "0.0.45",
"version": "0.0.46",
"license": "MIT",
"scripts": {
"lint": "eslint 'src/**/*.ts'",
Expand Down
2 changes: 1 addition & 1 deletion clients/ts-sdk/src/fetch-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
}

const response = await fetch(this.baseUrl + updatedPath, {
credentials: "include",
credentials: "omit",
method,
headers: headers,
body: requestBody ? JSON.stringify(requestBody) : undefined,
Expand All @@ -174,7 +174,7 @@
});

if (!response.ok) {
throw new Error(

Check failure on line 177 in clients/ts-sdk/src/fetch-client.ts

View workflow job for this annotation

GitHub Actions / tests

Unhandled error 

Error: HTTP error! status: {"message":"Not Found: Chunk with tracking_id not found in the specified dataset"} 
Payload undefined 
route: delete https://api.trieve.ai/api/chunk/tracking_id/1234
 ❯ TrieveFetchClient.fetch src/fetch-client.ts:177:13
 ❯ processTicksAndRejections node:internal/process/task_queues:95:5

This error originated in "src/functions/organization/organization.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "create an expired api key and verify it does not work". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
`HTTP error! status: ${await response.text()} \nPayload ${JSON.stringify(
requestBody
)} \nroute: ${method} ${this.baseUrl + updatedPath}`
Expand Down
7 changes: 0 additions & 7 deletions server/src/public/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,13 +312,6 @@
%} {% include "search-component-code.html" %} {% endif %}
</div>
</main>
{% if logged_in %}
<a
class="dev-back-button"
href="{{dashboard_url}}/dataset/{{params.datasetId}}/public-page"
>Back To Dashboard</a
>
{% endif %}
</body>

<canvas id="canvas"></canvas>
Expand Down
2 changes: 2 additions & 0 deletions server/src/public/product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ <h4 class="text-sm text-gray-500 mt-2 w-fit">
group_size: 1,
page_size: 8,
}),
credentials: "omit",
}
);
const recommendationsData = await recommendations.json();
Expand Down Expand Up @@ -200,6 +201,7 @@ <h6 class="rec-price mt-1 text-sm text-gray-700">${price}</h6>
Authorization: "Bearer " + window.paramsData.apiKey,
"TR-Dataset": window.paramsData.datasetId,
},
credentials: "omit",
}
);
const group = await getGroupByTrackingIdResp.json();
Expand Down
Loading