Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add floating action button to docsearch #2949

Merged
merged 2 commits into from
Dec 16, 2024
Merged

feature: add floating action button to docsearch #2949

merged 2 commits into from
Dec 16, 2024

Conversation

vid277
Copy link
Contributor

@vid277 vid277 commented Dec 16, 2024

image

@vid277 vid277 linked an issue Dec 16, 2024 that may be closed by this pull request
feature: add a hover button with a prop to enable/disable in a specified corner of page #2947
Closed
skeptrunedev
skeptrunedev requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment •
edited by vid277
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • position needs to be a prop
  • on/off flag for the floating button needs to be a prop
  • readme needs to get new documentation for props
  • example should get new env for testing prop on/off + position

@skeptrunedev skeptrunedev force-pushed the vs/feature-docsearch-floating-action-button branch from c80483a to 6dc14bb Compare December 16, 2024 19:37
@skeptrunedev skeptrunedev force-pushed the vs/feature-docsearch-floating-action-button branch from 7fc08c4 to 98742e6 Compare December 16, 2024 20:06
@skeptrunedev skeptrunedev merged commit 6483310 into main Dec 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: add a hover button with a prop to enable/disable in a specified corner of page
2 participants
@vid277 @skeptrunedev