feature: incrementally add pages #2932
Merged
+519
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeptrunedev
previously requested changes
Dec 12, 2024
There was a problem hiding this comment.
- feature: make the upload for a file be a signed PUT url instead of base64 (consider punting)
- feature: allow user to customize prompt on handler (also put in dashboard form)
- feature: allow user to specify heading_based chunking as an option instead of naive pages (make a group for each page)
- feature: page and link for each chunk
densumesh
force-pushed
the
ds/incrementally-add-pdf-pages
branch
from
2cb34d3 to
8b4fc48
Compare
This was
linked to
issues
Dec 14, 2024
3 tasks
densumesh
force-pushed
the
ds/incrementally-add-pdf-pages
branch
2 times, most recently
from
3b169c9 to
d6ca5d8
Compare
densumesh
force-pushed
the
ds/incrementally-add-pdf-pages
branch
from
d6ca5d8 to
5da1466
Compare
cdxker
approved these changes
Dec 14, 2024
cdxker
dismissed
skeptrunedev’s stale review
Reviewed and signed off, all requested features are added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please indicate what issue this PR is related to and @ any maintainers who are relevant