cleanup: reset to default key when provider URL changes

devflowinc · Dec 28, 2024 · df69663 · df69663
1 parent 3a55565
commit df69663
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 9 deletions.
diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml
@@ -28,20 +28,26 @@ jobs:
       - name: Running lint
         run: yarn lint:CI
       - name: Annotate Search Linting Results
-        uses: ataylorme/eslint-annotate-action@1.0.4
+        uses: ataylorme/eslint-annotate-action@3.0.0
         if: always()
         with:
-          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           report-json: "./frontends/search/eslint_report.json"
+          fail-on-error: true
+          fail-on-warning: true
       - name: Annotate Chat Linting Results
-        uses: ataylorme/eslint-annotate-action@1.0.4
+        uses: ataylorme/eslint-annotate-action@3.0.0
         if: always()
         with:
-          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           report-json: "./frontends/chat/eslint_report.json"
+          fail-on-error: true
+          fail-on-warning: true
       - name: Annotate Dashboard Linting Results
-        uses: ataylorme/eslint-annotate-action@1.0.4
+        uses: ataylorme/eslint-annotate-action@3.0.0
         if: always()
         with:
-          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           report-json: "./frontends/dashboard/eslint_report.json"
+          fail-on-error: true
+          fail-on-warning: true
diff --git a/frontends/dashboard/src/components/dataset-settings/LLMSettings.tsx b/frontends/dashboard/src/components/dataset-settings/LLMSettings.tsx
@@ -51,10 +51,15 @@ export const LLMSettings = (props: {
                   value={props.serverConfig().LLM_BASE_URL?.toString()}
                   onInput={(e) =>
                     props.setServerConfig((prev) => {
-                      return {
+                      const updatedConfig = {
                         ...prev,
                         LLM_BASE_URL: e.currentTarget.value,
                       };
+                      if (prev.LLM_BASE_URL !== e.currentTarget.value) {
+                        updatedConfig.LLM_API_KEY = null;
+                      }
+
+                      return updatedConfig;
                     })
                   }
                 >

diff --git a/frontends/dashboard/src/pages/dataset/PublicPageSettings.tsx b/frontends/dashboard/src/pages/dataset/PublicPageSettings.tsx
@@ -1350,8 +1350,8 @@ export const TabOptions = () => {
         <label class="block pt-4" for="">
           Message HTML
           <div class="text-xs text-neutral-500">
-            This is the HTML that will be displayed on the demo page under
-            that tab
+            This is the HTML that will be displayed on the demo page under that
+            tab
           </div>
         </label>
         <HtmlEditor