Probe changes in OpenShift template

[michael-valdron]

Signed-off-by: Michael Valdron [email protected]

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Updates the probing in the OpenShift template to ensure the registry index server is ready before launching the registry viewer.

Which issue(s) this PR fixes:

Link to github issue(s)

part of devfile/api#1019

PR acceptance criteria:

• Contributing guide
  Have you read the devfile registry contributing guide and followed its instructions?
• Test automation
  Does this repository's tests pass with your changes?
• Documentation
  Does any documentation need to be updated with your changes?
• Check Tools Provider
  Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[kim-tsao]

If we don't specify the liveness and readiness probes for the viewer, does that mean they will be created with the defaults?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michael-valdron]

If we don't specify the liveness and readiness probes for the viewer, does that mean they will be created with the defaults?

Yes, this would be the case here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes