Skip to content

Conversation

@michael-valdron
Copy link
Member

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Updates provided to build scripts and community devfile registry OpenShift template file to support new registry viewer setup. No stacks or samples updated.

Which issue(s) this PR fixes:

Link to github issue(s)

fixes devfile/api#747

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

With how the OpenShift CI builds container images, we'll probably need to force merge this in, but we can coordinate this on tomorrow's call.

Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

blocked by devfile/registry-support#153

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the build pipeline to use new Registry Viewer

2 participants