Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme for the public devfile registry - registry.devfile.io #14

Merged
merged 12 commits into from
Apr 6, 2021
Merged

Update readme for the public devfile registry - registry.devfile.io #14

merged 12 commits into from
Apr 6, 2021

Conversation

johnmcollier
Copy link
Member

Supersedes #12
Fixes devfile/api#390

Various readme fixes / updates now that the public registry is now available

  • Explicitly mentions the public registry and its URL in the readme
  • Mentions the update timeline for the public registry, and how requests for an update can be made
    • Should we formalize this anywhere other than the readme @elsony?
  • Adds a brief overview over the difference between staging (registry.stage.devfile.io) and production (registry.devfile.io)
  • Adds a stub contributing doc for adding devfile stacks
    • Just includes the bare minimum right now (testing with odo, building, where to put the stack folder, etc), as we don't have the stack author's guide written or available

elsony
elsony requested changes Mar 30, 2021
View reviewed changes
@johnmcollier
Copy link
Member Author

@elsony @GeekArthur Thanks for all of your review comments 👍 . I've updated the PR to address them, please re-review when you get the chance, thanks!

elsony
elsony reviewed Mar 31, 2021
View reviewed changes
GeekArthur
GeekArthur approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@GeekArthur GeekArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Looks good to me label Apr 6, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeekArthur, johnmcollier

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier johnmcollier merged commit d3a4244 into devfile:master Apr 6, 2021
johnmcollier added a commit to johnmcollier/registry that referenced this pull request Jul 8, 2021
@johnmcollier
Migrate registry build tools over from devfile/registry (devfile#14)
7341cb2 
* Migrate registry build tools over from devfile/registry

Signed-off-by: John Collier <[email protected]>

* Address review comments

Signed-off-by: John Collier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsony elsony elsony requested changes

@GeekArthur GeekArthur GeekArthur approved these changes

Assignees

@elsony elsony

@GeekArthur GeekArthur

Labels
lgtm Looks good to me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define timeline / process for updating stacks in the public devfile registry - registry.devfile.io
4 participants
@johnmcollier @openshift-ci-robot @elsony @GeekArthur