Skip to content

Conversation

@michael-valdron
Copy link
Member

Please specify the area for this PR

build-tools

What does does this PR do / why we need it:

Bumps yq to v4.44.1 to fix issues found in older v4 versions of yq.

Changes also include:

Which issue(s) this PR fixes:

Fixes #?

related devfile/api#1142

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Run bash build-tools/cache_samples.sh tests/registry/extraDevfileEntries.yaml .cache/samples

Fixes problem where if a cached sample directory exists build-tools/cache_samples.sh breaks, resolved by skipping directory creation if exists, related to devfile/api#1553

Run STACKS_DIR=tests/registry/stacks bash build-tools/dl_starter_projects.sh

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@michael-valdron
Copy link
Member Author

N/A

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Both bash build-tools/cache_samples.sh tests/registry/extraDevfileEntries.yaml .cache/samples and STACKS_DIR=tests/registry/stacks bash build-tools/dl_starter_projects.sh produced expected results.

Usually yq gives me a headache on Mac but it ran smoothly, I think the bump to the version fixed some issues or something!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 89fc566 into devfile:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants