Skip to content

Conversation

@thepetk
Copy link
Contributor

@thepetk thepetk commented Apr 4, 2024

Please specify the area for this PR

/area registry-library

What does does this PR do / why we need it:

This PR simply reverts the removal of the nosec comment related to the G304 code here: 20ce96d

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2024

@thepetk: The label(s) area/registry-library cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area registry-library

What does does this PR do / why we need it:

This PR simply reverts the removal of the nosec comment related to the G304 code here: 20ce96d

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thepetk thepetk requested a review from Jdubrick April 4, 2024 09:53
@openshift-ci openshift-ci bot requested a review from elsony April 4, 2024 09:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@codecov
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.27%. Comparing base (34df2fe) to head (e0df415).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files           7        7           
  Lines        2009     2009           
=======================================
  Hits          548      548           
  Misses       1414     1414           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This issue takes care of https://github.com/devfile/registry-support/security/code-scanning/92, code scanning is flagging it even though our changes prevent the inclusion it is referencing

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit d10fc19 into devfile:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants