-
Notifications
You must be signed in to change notification settings - Fork 28
adding build scripts to extract stack resources #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mike-hoang: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47 ☔ View full report in Codecov by Sentry. |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the change requests it would be good to have a few additional stacks (or stack versions) with a parent stack uri to test the dl_parent_devfiles.sh script on.
Signed-off-by: Michael Hoang <[email protected]>
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michael-valdron, mike-hoang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area registry
What does does this PR do / why we need it:
Adds
extract_resources.shAdds
dl_parent_devfiles.shWhich issue(s) this PR fixes:
Fixes devfile/api#1220
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
To test locally:
STACK_DIRtoSTACKS_DIR=tests/registry/stacksbash /registry-support/build-tools/extract_resources.sh,bash /registry-support/build-tools/dl_parent_devfiles.shTo test with the registry build script:
bash build.sh offlineVerify that resources are inside the stack:
docker run --rm -it --entrypoint bash devfile-indexcd /registry/stacks/