Skip to content

Conversation

@kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Nov 1, 2022

Signed-off-by: Kim Tsao [email protected]

Please specify the area for this PR

What does does this PR do / why we need it:

Removes unnecessary telemetry events from download calls

Which issue(s) this PR fixes:

Fixes #?
devfile/api#933

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Manually tested by building index server that was locally deployed and observing events in a test Segment instance

Signed-off-by: Kim Tsao <[email protected]>
@kim-tsao kim-tsao requested a review from johnmcollier November 1, 2022 15:55
@openshift-ci openshift-ci bot requested a review from elsony November 1, 2022 15:55
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 43.14% // Head: 42.88% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (8e08ab4) compared to base (47b3ffa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   43.14%   42.88%   -0.27%     
==========================================
  Files           6        6              
  Lines         985      991       +6     
==========================================
  Hits          425      425              
- Misses        519      525       +6     
  Partials       41       41              
Impacted Files Coverage Δ
index/server/pkg/server/endpoint.go 35.17% <0.00%> (ø)
index/server/pkg/util/telemetry.go 72.60% <0.00%> (-6.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@kim-tsao kim-tsao merged commit f16affc into devfile:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants