Skip to content

Conversation

@kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented May 3, 2022

Signed-off-by: Kim Tsao [email protected]

Please specify the area for this PR
/area telemetry

What does does this PR do / why we need it:
filters out server side, console events from segment. We collect client side events so this change has no impact to our analytics other than to reduce the noise

Which issue(s) this PR fixes:

Fixes #?
devfile/api#837

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

@kim-tsao: The label(s) area/telemetry cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Kim Tsao [email protected]

Please specify the area for this PR
/area telemetry

What does does this PR do / why we need it:
filters out server side, console events from segment. We collect client side events so this change has no impact to our analytics other than to reduce the noise

Which issue(s) this PR fixes:

Fixes #?
devfile/api#837

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from elsony and maysunfaisal May 3, 2022 16:08
@kim-tsao kim-tsao requested review from johnmcollier and removed request for elsony May 3, 2022 16:09
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@kim-tsao kim-tsao merged commit cb52e6c into devfile:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants