Skip to content

Modified docs to adhere to schema_4th PR #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 12, 2021
Merged

Modified docs to adhere to schema_4th PR #46

merged 7 commits into from
Apr 12, 2021

Conversation

@jc-berger
Copy link
Contributor

@jc-berger jc-berger commented Mar 4, 2021

For Jira #2557.

See related GitHub issues:

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Mar 4, 2021
@jc-berger jc-berger self-assigned this Mar 4, 2021
elsony
elsony requested changes Mar 5, 2021
View reviewed changes
maysunfaisal
maysunfaisal requested changes Mar 15, 2021
View reviewed changes
@jc-berger
Copy link
Contributor Author

jc-berger commented Mar 23, 2021

@maysunfaisal, @elsony, and/or @l0rd, I've made a new commit, addressing the feedback. Let me know if you guys think it's ready for the LGTM label.

I've initiated a doc review as well, so I'll be getting some feedback on the language here soon.

elsony
elsony requested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the Procedure section. The examples under Procedure section should be removed since we no longer support defining plugin in devfile.

@yhontyk
Copy link
Contributor

yhontyk commented Mar 25, 2021

LGTM

l0rd
l0rd reviewed Mar 25, 2021
View reviewed changes
@jc-berger
Copy link
Contributor Author

jc-berger commented Mar 25, 2021

@elsony, new, squashed commit is up, addressing yours and Mario's feedback. Let me know if it looks good to merge, and I'll remove the WIP in the title, thanks!

elsony
elsony approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

l0rd
l0rd reviewed Mar 25, 2021
View reviewed changes
l0rd
l0rd reviewed Mar 25, 2021
View reviewed changes
@jc-berger
modified docs to adhere to schema_4th PR
27a36df 
minor tweaks to yaml

minor change to migrating commands doc

added infor on more devfile v2 features

removed procedure from plugin doc and other minor changes

fixed devfile v2.x

minor language change to bullet point
@jc-berger jc-berger changed the title WIP: modified docs to adhere to schema_4th PR Modified docs to adhere to schema_4th PR Mar 26, 2021
rkratky
rkratky reviewed Mar 26, 2021
View reviewed changes
@jc-berger
Copy link
Contributor Author

jc-berger commented Mar 26, 2021

@rkratky, a lot of these changes I've made in PR #39

Should I make the same changes here as well, or should we wait until we push PR 39?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, jc-berger, l0rd, maysunfaisal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkratky rkratky merged commit d737726 into devfile:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkratky rkratky rkratky left review comments

@l0rd l0rd l0rd approved these changes

@elsony elsony elsony approved these changes

@maysunfaisal maysunfaisal maysunfaisal approved these changes

Assignees

@l0rd l0rd

@elsony elsony

@maysunfaisal maysunfaisal

@jc-berger jc-berger

Labels

documentation Improvements or additions to documentation lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent devfile docs wrt schema 2.x.x Errors in devfile 2.0.0 documentation Git attributes tag, commitId, and branch

7 participants

@jc-berger @yhontyk @openshift-ci-robot @l0rd @rkratky @elsony @maysunfaisal