Skip to content

Conversation

@svor
Copy link
Contributor

@svor svor commented Jun 7, 2022

Signed-off-by: svor [email protected]

Describes a troubleshooting for the node-debug2 plugin conversion fail

Related issue: https://issues.redhat.com/browse/CRW-3042

@svor svor requested review from ibuziuk and rkratky June 7, 2022 06:53
@svor svor self-assigned this Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

🎊 Navigate the preview: https://devfile-docs-158.surge.sh 🎊

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor language suggestion

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jun 7, 2022
@svor svor force-pushed the sv-node-debug-trouble branch from 490c300 to f678e9a Compare June 7, 2022 10:33
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2022

@nickboldt: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@svor svor force-pushed the sv-node-debug-trouble branch 2 times, most recently from d64e4ea to 9dc4273 Compare June 7, 2022 14:05
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, nickboldt, rkratky, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jun 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2022

New changes are detected. LGTM label has been removed.

@svor svor force-pushed the sv-node-debug-trouble branch from 9951865 to 3ea952c Compare June 7, 2022 14:48
@svor svor merged commit aa9671c into devfile:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants