Skip to content

Don't add contributions' resource limits/requests to containers that do not define them #1056

@amisevsk

Description

@amisevsk

Description

When a DevWorkspace component does not specifiy a memory/cpu limit/request, but a contribution is merged that does, DWO will add the resource requirement from the contribution to zero, resulting in a potentially much lower request/limit than expected.

How To Reproduce

The code-latest.yaml sample in this repo uses a dev container that does not specify limits/requests (for simplicity). When the workspace is started in a cluster, the dev container gets the limits/requests from the editor only (e.g. 500m cpu limit), which may be unintentional.

In an extreme case, merging a contribution that has very low limits/requests could result in the dev container failing to run anything useful.

Expected behavior

If the target for merging a contribution does not define a resource field, it should be undefined in merged component

Additional context

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions