This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
compile with RN 0.40.0 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for your contribution In the simulator works perfect, but in my phone closes the application, I have Android 5.1 know something about it? |
|
Hi, sorry I don't have android in hands, maybe you can check the worker files written in WorkerModule.java: "assets://workers/" + jsFileSlug + ".bundle" |
|
@keinsolrac I had not defined assets location , I placed worker.js outside along with index.android.js , it worked fine @weixingsun thanks for the build it works fine for android too |
|
Can this be merged ? |
|
@devfd, we need this feature as soon as possible! Please, cloud you accept this pull request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works in ios, only compiled in android