Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abstract from data structure in client #60

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Conversation

raveclassic
Copy link
Contributor

BREAKING CHANGE: apiClient dependency was renamed to httpClient
BREAKING CHANGE: APIClient was renamed to HTTPClient and now extends MonadThrow
BREAKING CHANGE: FullAPIRequest/APIRequest were joined and renamed to Request

closes #48

BREAKING CHANGE: apiClient dependency was renamed to httpClient
BREAKING CHANGE: APIClient was renamed to HTTPClient<F> and now extends MonadThrow<F>
BREAKING CHANGE: FullAPIRequest/APIRequest were joined and renamed to Request

closes #48
@raveclassic raveclassic requested a review from sutarmin October 29, 2019 17:59
@raveclassic raveclassic mentioned this pull request Oct 31, 2019
1 task
Copy link
Contributor

@sutarmin sutarmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raveclassic raveclassic merged commit bb53cc7 into master Oct 31, 2019
@raveclassic raveclassic deleted the api-client branch October 31, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract from Observable in APIClient
2 participants