Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolved relative urls for windows #5

Merged
merged 2 commits into from
Aug 7, 2015

Conversation

mankdev
Copy link
Contributor

@mankdev mankdev commented Aug 5, 2015

Plugin uses module "path" for building result relative url. But on windows platform it use '//' as path separator. So on windows we get urls that can't be understand by browsers.

@cakeinpanic
Copy link
Collaborator

@mankdev I think it should be separate method with speaking name

@mankdev
Copy link
Contributor Author

mankdev commented Aug 7, 2015

@cakeinpanic please take a look

BTW I suppose that we should split processUrlRebase function body into several functions, because now, it makes a lot of action: url resolving, renaming. If you agree please create separate task

@cakeinpanic
Copy link
Collaborator

@mankdev i agree with you, but there is no need in standalone issue, i'll do it within #3

cakeinpanic added a commit that referenced this pull request Aug 7, 2015
Fix urls resolving for windows
@cakeinpanic cakeinpanic merged commit 2ddca36 into devex-web-frontend:master Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants