-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create titiler namespaces packages #284
Conversation
) | ||
) -> TileMatrixSet: | ||
"""TileMatrixSet Dependency.""" | ||
return tms.get(TileMatrixSetId.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved all custom
code to the application
part
max-complexity = 12 | ||
max-line-length = 90 | ||
|
||
[mypy] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved the linters config to setup.cfg
] | ||
extra_reqs = { | ||
"test": ["pytest", "pytest-cov", "pytest-asyncio", "requests"], | ||
"server": ["uvicorn[standard]>=0.12.0,<0.14.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uvicorn is optional (e.g when running the application in AWS Lambda you don't need Uvicorn)
|
||
from geojson_pydantic.features import Feature | ||
|
||
|
||
def get_hash(**kwargs: Any) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function wasn't used in titiler
skip_install = true | ||
commands_pre = | ||
python -m pip install titiler/core | ||
python -m pip install titiler/application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because titiler-application depends on titiler-core, we install them manually
Still awaiting for feedback but if we move forward with namespaces here is IMO what we could do:
Maybe
|
Quick notes from chat
|
ref: #278
Why
As mentioned in #278, TiTiler is much more than an application, it's a python module that lets user create custom Tiler.
I believe that splitting
core
andapplication
could help users to have a better understanding but also help us to move quickly on some features.How
Tiler factories, ressources and models
demo
applicationbasic application (adds Uvicorn, python-dotenv and brotli dependencies)
main changes
custom
(colormap, tms) to the demo applicationtitiler.utils.get_hash
pkg_resources
to locate templates filesother
To Do