-
Notifications
You must be signed in to change notification settings - Fork 10
Support icechunk #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support icechunk #101
Conversation
Co-authored-by: Henry Rodman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably take those out?
src/titiler/multidim/reader.py
Outdated
|
|
||
| authorize_virtual_chunk_access = authorize_virtual_chunk_access or {} | ||
|
|
||
| print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}") |
|
@hrodmn this is ready for a review! Please ignore the tons of files in the test fixtures (sorry they clobber the diff quite a bit). |
hrodmn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great - nice work @jbusecke! The only changes I request are to avoid using assertions for raising errors in the actual runtime code.
For context on the configuration and deployment, the value that we set for TITILER_MULTIDIM_AUTHORIZED_CHUNK_ACCESS will be added as a secret value in a SSM secret that gets shared by multiple applications in a given deploy environment, so we may only have to define it once per deployment environment even if multiple applications want to use the same values.
titiler-multidim/.github/actions/cdk-deploy/action.yml
Lines 50 to 61 in 31c20aa
| - name: Get relevant environment configuration from aws secrets | |
| if: inputs.env_aws_secret_name != '' | |
| shell: bash | |
| working-directory: ${{ inputs.dir }} | |
| env: | |
| AWS_DEFAULT_REGION: us-west-2 | |
| run: | | |
| if [[ -z "${{ inputs.script_path }}" ]]; then | |
| ./scripts/sync-env.sh ${{ inputs.env_aws_secret_name }} | |
| else | |
| python ${{ inputs.script_path }} --secret-id ${{ inputs.env_aws_secret_name }} | |
| fi |
|
Thanks so much for the review @hrodmn. Ill see if I can get this cleaned up and ready for Monday! |
Replacing #96 since we cannot deploy to sandbox from a fork.
Depends on #95 and developmentseed/titiler#1235
Tasks