Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on obstore's NotFoundError #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Feb 3, 2025

Closes #197

@kylebarron kylebarron enabled auto-merge (squash) February 3, 2025 16:07
@ion-elgreco
Copy link

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

@kylebarron
Copy link
Member Author

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

@ion-elgreco
Copy link

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

@kylebarron
Copy link
Member Author

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

@martindurant
Copy link
Contributor

Simplest would be to subclass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotFoundError is not raised, but Python FileNotFoundError is raised
3 participants