Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine config and kwargs #180

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Combine config and kwargs #180

merged 2 commits into from
Jan 30, 2025

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 30, 2025 •
edited
Loading

This enables merging any parameters that are in config and kwargs for each store. If any config key is passed in both config and kwargs (even if spelled differently or cased differently), an error will be raised.

Closes #178

@kylebarron kylebarron enabled auto-merge (squash) January 30, 2025 19:11
@kylebarron kylebarron merged commit 5082d96 into main Jan 30, 2025
4 checks passed
@kylebarron kylebarron deleted the kyle/combine-config-kwargs branch January 30, 2025 19:13
@kylebarron kylebarron mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that config parameters are passed either in the config dict or in kwargs but not both
1 participant
@kylebarron