Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement read_all for async iterable #140

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Implement read_all for async iterable #140

merged 4 commits into from
Jan 15, 2025

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 14, 2025 •
edited
Loading

Change list

  • Implement read_all for AsyncPushSource
  • Change read_all to not copy buffer protocol input.

@kylebarron kylebarron marked this pull request as draft January 14, 2025 22:41
@kylebarron kylebarron marked this pull request as ready for review January 15, 2025 15:43
@kylebarron kylebarron enabled auto-merge (squash) January 15, 2025 15:47
@kylebarron
Copy link
Member Author

I'm not sure why but the tests just hung on c7f154f (#140). I reverted to using &mut self in read_all and we'll see if that does better.

@kylebarron kylebarron merged commit a14fb61 into main Jan 15, 2025
4 checks passed
@kylebarron kylebarron deleted the kyle/put-inner-read-all branch January 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron