Skip to content

Use sys.exectuable in place of python string, close #123 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wronk merged 2 commits into from
Dec 7, 2018
Merged

Use sys.exectuable in place of python string, close #123 #124

wronk merged 2 commits into from
Dec 7, 2018

Conversation

@drewbo
Copy link
Contributor

@drewbo drewbo commented Dec 7, 2018 •
edited by wronk
Loading

closes #123

@drewbo drewbo requested a review from wronk December 7, 2018 15:09
@vpipkt
Copy link

vpipkt commented Dec 7, 2018

👍

wronk
wronk approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@wronk wronk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wronk wronk merged commit 7b8953c into master Dec 7, 2018
@wronk wronk deleted the bug/123-python-naming branch December 7, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wronk wronk wronk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

labels subcommand broken by default python

4 participants

@drewbo @vpipkt @wronk