Add support for geojson labels #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wronk
approved these changes
Nov 1, 2018
Contributor
wronk
left a comment
wronk
left a comment
There was a problem hiding this comment.
Minor comments to address. Glad to see this functionality going in :)
I'm happy with this as soon as you get the tests to work
| geojson = json.load(geojson_file) | ||
|
|
||
| for feature in geojson['features']: | ||
| self.assertTrue(feature in expected_geojson['features']) |
Contributor
There was a problem hiding this comment.
I think it's true that the number of features should be the same. If so, try assertCountEqual. The name is a little misleading, but it checks that both (potentially unordered) lists have the same elements.
Contributor
There was a problem hiding this comment.
Might also be able to use this on the numpy array check right above
Co-Authored-By: drewbo <[email protected]>
Co-Authored-By: drewbo <[email protected]>
…ker into feature/geojson
drewbo
force-pushed
the
feature/geojson
branch
from
33311d2 to
f450ce3
Compare
drewbo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A functional but unclean implementation of #32. To merge this properly it still needs: