Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validate function to load from a string. #88

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Remove validate function to load from a string. #88

merged 2 commits into from
Aug 8, 2022

Conversation

eseglem
Copy link
Collaborator

@eseglem eseglem commented Aug 7, 2022

Per further discussion in: #66 (comment)

Can use pydantic.Json[Polygon] in a model to load from string.

eseglem and others added 2 commits August 6, 2022 21:31
@eseglem
Remove validate function to load from a string.
bf206da 
Can use `pydantic.Json[Polygon]` in a model to load from string.
@vincentsarago
fix conflict and update changelog
10cba47
@vincentsarago vincentsarago self-requested a review August 8, 2022 08:21
vincentsarago
vincentsarago approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@vincentsarago vincentsarago merged commit 6a32302 into developmentseed:master Aug 8, 2022
@eseglem eseglem deleted the feature/remove-string-validation branch February 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eseglem @vincentsarago