Fix geo_interface output when bbox is None #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bbox
key should not be in a geojson object if the bbox isNone
. If the key is present, the value is expected to be a tuple, see https://datatracker.ietf.org/doc/html/rfc7946#section-5In ths PR, I also moved the
__geo_interface__
into a mixin to reduce code duplication.There is one design question where I was not sure what is the best:
The bbox check could be added into the
dict()
method directly. Depending on whether the expected output ofdict
is a valid geojson like dictionary, or the "full" data from the pydantic model. Please advise, I am happy to change that if its considered better to put it into thedict
method.