Remove unused LinearRingGeom class. #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
LinearRingGeom
class. It doesn't correspond with an actual GeoJSON type and it is not used in any other part of the code. It also had no tests or anything related to it.I think this probably originated from the desire to have the validation on the coordinates and not inside Polygon, but it was not actually being used. I have been experimenting with a class for
LinearRingCoords
that may end up similar with the validation is inside the type and not on Polygon. But if I can get it working that will be a different PR.How I did it
How you can test it
Related Issues