Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused LinearRingGeom class. #106

Merged

Conversation

eseglem
Copy link
Collaborator

@eseglem eseglem commented Feb 10, 2023

What I am changing

  • Remove the LinearRingGeom class. It doesn't correspond with an actual GeoJSON type and it is not used in any other part of the code. It also had no tests or anything related to it.

I think this probably originated from the desire to have the validation on the coordinates and not inside Polygon, but it was not actually being used. I have been experimenting with a class for LinearRingCoords that may end up similar with the validation is inside the type and not on Polygon. But if I can get it working that will be a different PR.

How I did it

  • Remove the LinearRingGeom class.

How you can test it

  • This code wasn't actually used anywhere, and didn't have any related tests.

Related Issues

@vincentsarago
Copy link
Member

🙏

@vincentsarago vincentsarago merged commit 23240df into developmentseed:main Feb 10, 2023
@eseglem eseglem deleted the feature/remove-unused-linearring branch February 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants