Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more Python methods #41

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Add two more Python methods #41

merged 3 commits into from
Oct 14, 2024

Conversation

gadomski
Copy link
Collaborator

What I am changing

  • Adds parse_text and parse_json allow us to be specific about how we parse, if we already know (e.g. if we have a filter lang)

Related Issues

`parse_text` and `parse_json` allow us to be specific about how we parse, if we
already know (e.g. if we have a filter lang)
@gadomski gadomski self-assigned this Oct 14, 2024
python/cql2.pyi Outdated Show resolved Hide resolved
@gadomski gadomski added the python Relates to the Python bindings label Oct 14, 2024
python/cql2.pyi Outdated Show resolved Hide resolved
python/cql2.pyi Outdated Show resolved Hide resolved
@gadomski gadomski changed the title Add two more static python methods Add two more Python methods Oct 14, 2024
@gadomski
Copy link
Collaborator Author

gadomski commented Oct 14, 2024

@vincentsarago and @kylebarron , re-requested review as I moved to free functions, which feels much better now that I look at it. Three functions to create expressions:

  • parse_text
  • parse_json
  • parse_file

Expr.__init__ still does parse-by-detect and converts Python dict to cql2-json.

@gadomski gadomski merged commit 5a590fd into main Oct 14, 2024
18 checks passed
@gadomski gadomski deleted the more-python-staticmethods branch October 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Relates to the Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants