Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Closure compiler #569

Closed
wants to merge 14 commits into from
+321 −209
Closed

Add Closure compiler #569

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e3534b8
add closure compiler option and implement it
JoviDeCroock Feb 17, 2020
efecc9c
update readme
JoviDeCroock Feb 17, 2020
35d6b7c
use the correct dep
JoviDeCroock Feb 17, 2020
73993d1
update snapshots
JoviDeCroock Feb 17, 2020
53f7523
fix typescript compilation for closure
JoviDeCroock Feb 17, 2020
2520202
only use in es and modern mode
JoviDeCroock Feb 17, 2020
fdb38d3
update to new version
JoviDeCroock Feb 17, 2020
79638e8
no strict directive
JoviDeCroock Feb 17, 2020
986cf9c
Merge branch 'master' into closure-compiler
JoviDeCroock Feb 17, 2020
d08fa57
remove node_modules from snapshot
JoviDeCroock Feb 17, 2020
ee6f99b
updateSnapshot didn't apply last time
JoviDeCroock Feb 18, 2020
71ca79a
remove the objectHashIgnoreUnknownHack option
JoviDeCroock Feb 24, 2020
c48ee08
Merge branch 'master' into closure-compiler
JoviDeCroock Feb 24, 2020
054c9d3
Merge branch 'master' into closure-compiler
JoviDeCroock Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updateSnapshot didn't apply last time
@JoviDeCroock
JoviDeCroock committed Feb 18, 2020
commit ee6f99ba10fee39837b7b36e213ef9cf0f4c6949
2 changes: 1 addition & 1 deletion src/index.js
View file
Original file line number Diff line number Diff line change
@@ -592,7 +592,7 @@ function createConfig(options, entry, format, writeMeta) {
},
}),
options.compress !== false && [
options.closure && (modern || format === 'es')
options.closure && (format === 'es' || modern)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clarify in the docs/help that Terser is always used for cjs,iife,umd formats, regardless of the --closure option.

? closureCompiler({ remove_strict_directive: true })
: terser({
sourcemap: true,
2 changes: 1 addition & 1 deletion test/__snapshots__/index.test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -57,6 +57,7 @@ async-iife-ts
async-iife-ts.umd.js
async-iife-ts.umd.js.map
index.d.ts
node_modules
package.json
src
index.ts
@@ -164,7 +165,6 @@ basic
basic-lib.js.map
basic-lib.umd.js
basic-lib.umd.js.map
node_modules
package.json
src
index.js