Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bind decorator bug when super method is called #12

Open
precious opened this issue Aug 31, 2017 · 5 comments
Open

@bind decorator bug when super method is called #12

precious opened this issue Aug 31, 2017 · 5 comments

Comments

@precious
Copy link

This snippet demonstrates that the bind decorator does not work correctly on second method call if that method invokes super method which in turn is also decorated:

class A {
    @bind
    f() {
        console.log('I\'m A.f');
    }
}

class B extends A {
    @bind
    f() {
        console.log('I\'m B.f BEGIN');
        super.f();
        console.log('I\'m B.f END');
    }
}

let b = new B();
console.log('call b.f() 1st time:');
b.f();
console.log('call b.f() 2nd time:');
b.f();

Output:

call b.f() 1st time:
I'm B.f BEGIN
I'm A.f
I'm B.f END
call b.f() 2nd time:
I'm A.f
@precious
Copy link
Author

precious commented Sep 2, 2017

This bug can be reproduced with babel es2015 preset.
With .babelrc config

{"presets": ["es2015"], "plugins": ["transform-decorators-legacy"]}

and mocha option --compilers js:babel-core/register.

@developit
Copy link
Owner

Hmm interesting. I've never used this with prototypal inheritance, I can see how it'd overwrite itself like that. Not sure what the best solution for this would be, seems like any fix would break the lazy-binding behavior, which is sortof the big selling feature of this method.

precious pushed a commit to precious/decko that referenced this issue Sep 3, 2017
@precious
Copy link
Author

precious commented Sep 3, 2017

This fix may help. It prevents defineProperty for this if property is accessed from a super class.
Let me know if this solution is acceptable -- I'll create a pull request.

@wy193777
Copy link

@memoize also not working when super class' method is called.

@Finesse
Copy link

Finesse commented Feb 4, 2019

How does the example even work? When I run it, I get an error:

Cannot set property f of #<B> which has only a getter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants