Repository navigation
ci: gate integrity — foundations - #25
Merged
Merged
Conversation
- `network` fixture: offline()/drop()/online() over an offline gate in the sealed network, ahead of the mocks so the app's own offline path runs. New X_TEST_NETWORK_OFFLINE. - `page`, `budget`, `signIn`, `deploy`, `subscribe` declared in fixture-drivers.ts: the name resolves and asking for it without a browser or a replicator fails as X_TEST_FIXTURE_UNAVAILABLE naming the driver — not X_TEST_FIXTURE_UNKNOWN, whose fix would have each app inventing its own idea of what a page is. A driver arrives through defineFixtures; no second seam. - Fixtures type widened to the full bag; PageLike grown to the members the reference app actually calls. - examples/dummy keeps only seed + actorFor. Its 11 X_TEST_FIXTURE_UNKNOWN failures are now 11 X_TEST_FIXTURE_UNAVAILABLE (6 page, 5 subscribe). Co-Authored-By: Claude <noreply@anthropic.com>
- new site/tsconfig.json, referenced from the root — `tsc -b` never walked site/, so build.ts and lib/* shipped untypechecked - empty `paths` there: site/ is its own bundle graph (axiom 6), so an @ultimat3/* import is now a resolution error, not a convention - declare the frontmatter vocabulary as `PageMeta`, clearing the 24 TS4111s a bare Record produced; `meta.nav` is checked, `meta.navv` is not a property - typecheck step summary said "every workspace"; site/ is not one - parse.test.ts fixture gave `verify` an `--only` flag it does not and must not have — moved the string-flag case onto `db --name` Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe testing package adds framework and driver-backed fixtures, unavailable-driver errors, and process-global network controls. The site becomes a referenced TypeScript project with typed page metadata. CLI parser tests now cover ChangesTesting fixtures and network controls
Site project verification
CLI parser fixtures
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Test
participant TestNetwork
participant SealedNetwork
participant Fetch
participant NetworkOfflineError
Test->>TestNetwork: offline() or drop()
TestNetwork->>SealedNetwork: setNetworkState(mode)
Fetch->>SealedNetwork: request URL and method
SealedNetwork->>NetworkOfflineError: reject non-online request
Test->>TestNetwork: dispose()
TestNetwork->>SealedNetwork: restore online state and sealing
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/dummy/scripts/test-setup.ts`:
- Around line 1-5: Reduce the header comment above the test preload setup to no
more than four lines while preserving its statement that the file registers only
Postly-owned fixtures: the seed graph and member-to-actor setup.
In `@packages/cli/src/parse.test.ts`:
- Line 87: Update the missing-value test around parseArgs to capture the thrown
error with thrownBy, then assert its stable X_CLI_BAD_FLAG code and the “expects
a value” cause instead of only checking that any exception occurs. Preserve the
existing db branch --name input and SPECS setup.
In `@packages/testing/src/fixture-drivers.test.ts`:
- Line 18: Update the outer describe suite in the declared-but-driverless
fixtures test to import and use testName('unit', 'the declared-but-driverless
fixtures') as its suite name, preserving the existing suite body.
In `@packages/testing/src/fixture-drivers.ts`:
- Around line 1-10: Shorten the header in
packages/testing/src/fixture-drivers.ts (lines 1-10) to 1–4 lines stating the
file’s responsibility and rationale. Apply the same reduction to
packages/testing/src/framework-fixtures.ts (lines 1-12), and add a 1–4 line
responsibility-and-rationale header before imports in
packages/testing/src/fixture-drivers.test.ts (lines 1-12).
In `@packages/testing/src/fixture-network.test.ts`:
- Line 21: Update the outer describe suite in the network fixture test to call
testName('unit', 'the network fixture') instead of using a literal suite name,
while leaving the nested test structure unchanged.
In `@packages/testing/src/fixture-network.ts`:
- Around line 36-55: Capture the existing NetworkState before any mutation in
the fixture setup, then restore that saved value in the returned object’s
[Symbol.dispose] instead of always setting the state to 'online'. Keep the
sealedByUs and sealedBefore cleanup behavior unchanged.
In `@packages/testing/src/fixtures.ts`:
- Around line 20-23: Update defineFixtures and its FixtureMap typing to preserve
each declared fixture’s type by checking factories for every keyof Fixtures
against Fixtures[K], while continuing to allow custom application fixture keys.
Revise the fixture-drivers test registration for page to provide a complete
PageLike-compatible driver, or add a compile-time assertion that rejects the
incomplete driver.
In `@packages/testing/src/index.ts`:
- Around line 77-89: Remove setNetworkState from the public exports in
packages/testing/src/index.ts lines 77-89. Keep the setNetworkState
implementation in packages/testing/src/sealed-network.ts lines 103-106 internal
for fixture implementation use, with no direct change required there beyond
preserving its non-public status.
In `@scripts/verify.test.ts`:
- Around line 83-90: Update the test around the existing site tsconfig assertion
to validate actual module resolution, not just compilerOptions.paths. In the
test module, create and compile a temporary probe importing `@ultimat3/core` with
site/tsconfig.json, then assert compilation fails with “Cannot find module
'`@ultimat3/core`'”; retain cleanup and the existing paths assertion as
appropriate.
In `@site/README.md`:
- Around line 64-72: Add “As of 2026-07” to the documentation paragraph
describing the site TypeScript project and bun run verify typecheck coverage,
while preserving the existing claims and wording.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4e8b0fd4-fb3e-4fcc-bff9-810a24887dfe
📒 Files selected for processing (24)
examples/dummy/CLAUDE.mdexamples/dummy/scripts/test-setup.tspackages/cli/src/cmd-verify.tspackages/cli/src/parse.test.tspackages/testing/CLAUDE.mdpackages/testing/README.mdpackages/testing/src/errors.tspackages/testing/src/fixture-drivers.test.tspackages/testing/src/fixture-drivers.tspackages/testing/src/fixture-network.test.tspackages/testing/src/fixture-network.tspackages/testing/src/fixtures.tspackages/testing/src/framework-fixtures.test.tspackages/testing/src/framework-fixtures.tspackages/testing/src/index.tspackages/testing/src/sealed-network.tspackages/testing/src/test-types.tsscripts/verify.test.tssite/README.mdsite/lib/config.tssite/tsconfig.jsontsconfig.jsonwiki/Error-Codes.mdwiki/Testing.md
- defineFixtures holds every declared name to its declared type, so a
half-built `page` driver is a compile error at the registration rather
than a missing method three awaits into a later test
- the network fixture restores the state it found on disposal instead of
forcing 'online' — an outer fixture already offline stayed offline
- setNetworkState is no longer exported: the gate's one writer is the
`network` fixture, and a direct call skipped its disposal
- parse.test.ts asserts X_CLI_BAD_FLAG + "expects a value", not any throw
- verify.test.ts compiles a probe under site/ and asserts @ultimat3/core
cannot resolve — the effect, not just the `paths` knob
- file headers cut to the 1-4 line convention; the rationale moved onto
the declarations it explains, not deleted
- testName('unit', …) on both new outer describes
- site/README.md dates its verification claims As of 2026-08
Co-Authored-By: Claude <noreply@anthropic.com>
- test-setup.ts: drop the `bunfig.toml` preload snippet the header restated; bunfig.toml already states it, and a fact in two places drifts (axiom 2). Leaves an unambiguous 3-line header. - site/README.md: the tree row duplicated the dated claim below it; trimmed to what the file is, so `As of 2026-08` states it once. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 10, 2026
This was referenced Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.json'stestscript and.github/workflows/ci.yml'stestjob carry no opt-in exclusions at all (commit1131e4e,already on
main);bun run testruns e2e (and contract/live/job/eval) every time. No codechange needed for this task; confirmed via a full local run (3481 pass/0 fail) and
bun run verify(17/17 green).Test plan
bun run verify— 17/17 greenbun run test— 3481 pass / 0 fail / 23 skipNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
Documentation
Bug Fixes