fix(build): unblock tinyvec 1.13.0 resolution - #1525
Closed
developer0hye wants to merge 1 commit into
Closed
Conversation
Explicitly enable tinyvec std in the published library manifest so Cargo feature unification avoids the upstream 1.13.0 alloc-only macro regression. Keep the workaround bounded to issue #1524 and remove it after a patched tinyvec release is verified. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Owner
Author
|
Closing unmerged because upstream tinyvec 1.13.1 is now published with the qualified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tinyvec'sstdfeature in the publishedoffice2pdfmanifestno_std + alloccode pathtinyvecis already in the dependency graph, and office2pdf is std-only, so this changes feature selection without adding a new compiled package. The permanent upstream fix is Lokathor/tinyvec#226 for Lokathor/tinyvec#225; that PR is independently validated but has not been merged or released yet.Related issue
Fixes #1524
Failure reproduced first
A fresh main worktree with no
Cargo.lockfailed as expected:Testing
CARGO_TARGET_DIR=/private/tmp/office2pdf-1524-before-target cargo check --workspaceCARGO_TARGET_DIR=/private/tmp/office2pdf-1524-before-target cargo test --workspaceCARGO_TARGET_DIR=/private/tmp/office2pdf-1524-before-target cargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkCARGO_TARGET_DIR=/private/tmp/office2pdf-tinyvec-std-wasm-target cargo check --target wasm32-unknown-unknown -p office2pdfCARGO_TARGET_DIR=/private/tmp/office2pdf-tinyvec-std-wasm-target cargo check --target wasm32-unknown-unknown -p office2pdf --features wasmCARGO_TARGET_DIR=/private/tmp/office2pdf-tinyvec-std-wasm-target cargo check --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-fontCARGO_TARGET_DIR=/private/tmp/office2pdf-1524-publish-target cargo publish --dry-run -p office2pdf --allow-dirtytinyvec = "1",features = ["std"], anddefault-features = falsePASS:Visual impact
Checklist
Signed-off-byline