fix(pptx): round hard-break seats per line - #1523
Merged
Merged
Conversation
Owner
Author
|
Exact-head CI run 33821140488 is blocked by the known upstream The commit-local gates that do not compile that dependency are green: DCO, Format, Release Automation Contract, Business Golden Contract, and Visual PR Contract. Local Upstream fix: Lokathor/tinyvec#226. This PR will remain unmerged until the consumer graph is healthy and exact-head CI is rerun. |
PowerPoint rounds a hard-broken line's seat at that line's own font size. Reusing a paragraph-wide split from the largest run rescaled smaller lines to fractional seats and shifted mixed-size stacks. Evaluate the validated PowerPoint split independently for each plain hard-break line while preserving explicit paragraph line-spacing behavior. Add a native PowerPoint fixture, exact regression coverage, and strict visual evidence for issue #1252. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
fix/issue-1252-hard-break-seat
branch
from
September 4, 2026 04:38
6f07d5c to
83a6da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Related: #1252
Testing
cargo test --locked --workspaceCARGO_TARGET_DIR=/private/tmp/office2pdf-1252-check cargo check --locked --workspaceCARGO_TARGET_DIR=/private/tmp/office2pdf-1252-check cargo clippy --locked --workspace --all-targets -- -D warningscargo fmt --all -- --checkpython3 scripts/compare_layout.py /private/tmp/office2pdf-1252-visual.aQu2pO/gt-isolated.pdf /private/tmp/office2pdf-1252-visual.aQu2pO/after-isolated.pdf --json --audit --fine-shift 0.12python3 scripts/compare_render.py /private/tmp/office2pdf-1252-visual.aQu2pO/gt-isolated.pdf /private/tmp/office2pdf-1252-visual.aQu2pO/after-isolated.pdf --page 1 --dpi 300 --artifacts-dir /private/tmp/office2pdf-1252-visual.aQu2pO/audit-isolated-page-1 --cluster-report assets/bugfixes/issue-1252/render-clusters-page-1.json --strict-clustersmagick compare -metric AE -fuzz 5%(before: 14,024 pixels; after: 12,754 pixels versus GT)Visual impact
Visual audit
tests/fixtures/pptx/hard_break_mixed_size_seat.pptxpdftoppm, 300 DPIfixassets/bugfixes/issue-1252/layout-audit.jsonassets/bugfixes/issue-1252/render-clusters-page-1.jsonassets/bugfixes/issue-1252/gt.jpgassets/bugfixes/issue-1252/before.jpgassets/bugfixes/issue-1252/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline