fix(pptx): honor custom geometry transforms - #1520
Merged
Merged
Conversation
Owner
Author
|
Exact-head CI run 33811496446 is externally blocked by the newly published Every failed Cargo job freshly resolved 1.13.0 and stopped inside Upstream tracking:
I will rerun this exact head after upstream publishes the correction or yanks 1.13.0. |
This was referenced Sep 3, 2026
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
fix/issue-1418-pptx-title-rule
branch
from
September 4, 2026 03:58
d52ae3d to
0ffd0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wandhaxis independently instead of discarding a declared axis when its peer is absentflipHandflipVto normalized custom-path vertices about the shape-box centerThe page-9 title rule now reaches the reference endpoint and sits on the reference baseline. The same root-cause correction improves the equivalent flipped rules on pages 5 and 6; the other twelve pages remain pixel-identical before/after.
Related issue
Fixes #1418. Related: #1220, #1419, #1519.
Testing
cargo test --locked -p office2pdf --lib a_single_declared_path_axis_scales_independently -- --nocapturecargo test --locked -p office2pdf --lib a_custom_geometry_path_follows_shape_flips -- --nocapturecargo test --locked -p office2pdf --lib a_custom_geometry_horizontal_flip_mirrors_only_x -- --nocapturecargo test --locked -p office2pdf --lib parser::pptx::custom_geometry::tests— 28 passedcargo test --locked -p office2pdf --lib shape_style_tests— 37 passedcargo test --locked --workspace --all-features— passed: 2,856 library tests, 188 DOCX fixtures, 130 PPTX fixtures, 207 XLSX fixtures, CLI/package tests, and doctests; only repository-declared ignores remaincargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkqpdf --check target/issue-1418/after.pdfPASSVisual impact
Visual audit
GENERAL SERVICES.pptxattachment from PPTX ordinary shape picture fill is omitted from slide 1 #1220, SHA-25617924ec3b27646a2c1b2bb711b845360b713cc7052b3cdde9df752f9ceded3a9; LibreOffice GT SHA-2568c8f471d8baaf0abd79e752ef49951c240752d36e4512651f6cb9a7cfffb650ffixassets/bugfixes/issue-1418/layout-audit.jsonassets/bugfixes/issue-1418/render-clusters-page-9.jsonassets/bugfixes/issue-1418/reference-exporter-differences.jsonassets/bugfixes/issue-1418/gt.jpgassets/bugfixes/issue-1418/before.jpgassets/bugfixes/issue-1418/after.jpgassets/bugfixes/issue-1418/native.jpgVisual comparison
ref:page-9-slide-number-visibilityref:page-9-title-font-native-match; none touches the corrected ruleThe page-9 text-layer census has no codepoint-class delta. Its normalized content differs only because the LibreOffice GT carries hidden
Sensitivity: Internalmetadata; all visible source text is preserved.Required inspection
Deviation audit
flipV; no unrelated rotation or flip changed.Sensitivity: Internalmetadata.Checklist
Signed-off-byline