Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image of Meet the team #102

Open
kush-daga opened this issue May 15, 2020 · 6 comments
Open

Fix Image of Meet the team #102

kush-daga opened this issue May 15, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@kush-daga
Copy link
Member

kush-daga commented May 15, 2020

The image is stretched and that is not right, make it such that it is contained in the height and width while maintaining the aspect ratio. Shubhank Bhaiya's Image

@welcome
Copy link

welcome bot commented May 15, 2020

Thanks for opening your first issue here! We are happy to have you on-board!

@kush-daga
Copy link
Member Author

Thanks for opening your first issue here! We are happy to have you on-board!

Sahi h

@kush-daga kush-daga self-assigned this May 15, 2020
@aniketbiswas21
Copy link
Member

It has been used as a placeholder. We need better images for home page.

@kush-daga
Copy link
Member Author

Still never give them height and widht on your own, only give height or only width to maintain the aspect ratio, and if giving both then make sure its cover or contain

@aniketbiswas21
Copy link
Member

I didn't understand the last point the cover and contain one.

@kush-daga
Copy link
Member Author

Ill show in the commit
object-fit: contain
css property which will solve this issur

kush-daga added a commit to kush-daga/officialWebsite that referenced this issue May 15, 2020
@shubhank-saxena shubhank-saxena added the bug Something isn't working label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants