Skip to content

Dev Container Id Proposal #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2022
Merged

Dev Container Id Proposal #96

merged 4 commits into from
Sep 22, 2022

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Sep 14, 2022 •
edited
Loading

Continuing from #62.

@chrmarti chrmarti requested a review from a team as a code owner September 14, 2022 08:58
@chrmarti chrmarti mentioned this pull request Sep 14, 2022
Closed
samruddhikhandale
samruddhikhandale approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

edgonmsft
edgonmsft approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@edgonmsft edgonmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkeech
jkeech approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a couple small suggestions/questions.

@chrmarti chrmarti merged commit 7423d54 into main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chuxel Chuxel Chuxel approved these changes

@jkeech jkeech jkeech approved these changes

@joshspicer joshspicer joshspicer approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

@edgonmsft edgonmsft edgonmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrmarti @Chuxel @jkeech @joshspicer @samruddhikhandale @edgonmsft