Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL support to node feature. #823

Conversation

jdputschadi
Copy link
Contributor

This PR adds RHEL support to node feature.

CentOS 7, RHEL/Alma/Rocky Linux 8 & 9, Mariner, and Fedor should all work. Tests for all of these are included.

resolves #822

@jdputschadi jdputschadi requested a review from a team as a code owner January 30, 2024 18:28
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another powerful PR 🎉

Thank you, left some minor comments

src/node/install.sh Outdated Show resolved Hide resolved
src/node/NOTES.md Outdated Show resolved Hide resolved
src/node/NOTES.md Outdated Show resolved Hide resolved
src/node/install.sh Show resolved Hide resolved
src/node/install.sh Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's wait for the tests, then we are good to merge! ⚡

@samruddhikhandale samruddhikhandale merged commit 4f0d020 into devcontainers:main Jan 31, 2024
11 checks passed
@jdputschadi jdputschadi deleted the node-feature-rhel-support branch January 31, 2024 19:31
@jdputschadi
Copy link
Contributor Author

Samruddhi: Thank you for helpful comments and good feedback. Glad to be able to help with the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RHEL support to node feature.
2 participants