Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Don't crash updating UID/GID when the image's platform is different from the native CPU arch #746

Merged
merged 14 commits into from
Feb 28, 2024
Merged

[FIX] Don't crash updating UID/GID when the image's platform is different from the native CPU arch #746

merged 14 commits into from
Feb 28, 2024

Commits on Feb 15, 2024

  1. add failing tests

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d726d52 View commit details
    Browse the repository at this point in the history

  2. install emulators in CI job

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f9b9f32 View commit details
    Browse the repository at this point in the history

  3. Parse PlatformInfo from buildxPlatform, plumb platformInfo through re… 

    …gistry calls, add Os and Architecture properties to ImageDetails, and pass --platform in updateRemoteUserUID
    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3f09719 View commit details
    Browse the repository at this point in the history

  4. map node os and arch to go values

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    419ef4d View commit details
    Browse the repository at this point in the history

  5. parse buildxPlatform into the Go forms

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    cb6415c View commit details
    Browse the repository at this point in the history

  6. clean up builder if test fails

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    892220e View commit details
    Browse the repository at this point in the history

  7. add platformInfo in a few places I missed

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    95e18ef View commit details
    Browse the repository at this point in the history

  8. remove .only

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c4d0ec3 View commit details
    Browse the repository at this point in the history

  9. only add --platform flag if platform isn't null

    @trxcllnt
    trxcllnt committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    053d5e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Fix platform architecture slice index

    @trxcllnt
    trxcllnt authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    488d60c View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. disallow buildxPlatform when using compose

    @trxcllnt
    trxcllnt committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ebba946 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/uuid-platform' of github.com:trxcllnt/devcontainers… 

    …-cli into fix/uuid-platform
    @trxcllnt
    trxcllnt committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1a17920 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. also respect the platform variant

    @trxcllnt
    trxcllnt committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4f60e02 View commit details
    Browse the repository at this point in the history

  2. add test for platform with variant component, tests for --platform pa… 

    …ssed as build option and run args
    @trxcllnt
    trxcllnt committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0ad405f View commit details
    Browse the repository at this point in the history