Improved and reliable secret masking #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret masking functionality that was added in #551 used regex for replacing secret values. One edge case is that if there are one or more secret values that are very large (say over 32K) we cannot create a regex for that (due to regex length limit).
Best alternative is to use
string.relaceAllfunction that is available in ES2021 and above. That also bring in additional benefits as documented here.In this PR
string.replaceAllmethod.Dependency
I have added the commit from that PR here, to make the checks pass. I will hold this one until that PR is merged.