Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated command #565

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Outdated command #565

merged 7 commits into from
Jul 3, 2023

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jun 26, 2023

Similar data to yarn's and NPM's outdated command. microsoft/vscode-remote-release#8640

E.g.:

$ devcontainer outdated --workspace-folder ../../smktst --config ../../smktst/.devcontainer/lockfile/devcontainer.json
[3 ms] @devcontainers/cli 0.46.0. Node.js v16.20.1. darwin 22.5.0 arm64.
{
  "features": {
    "ghcr.io/devcontainers/features/git:1.0": {
      "current": "1.0.4",
      "wanted": "1.0.5",
      "latest": "1.1.5"
    }
  }
}

@chrmarti chrmarti marked this pull request as ready for review June 28, 2023 11:43
@chrmarti chrmarti requested a review from a team as a code owner June 28, 2023 11:43
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question, besides that looks good to me!

src/spec-node/devContainersSpecCLI.ts Show resolved Hide resolved
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions:

  1. Features in my devcontainer.json without a version are omitted. Should we assume latest in this case and resolve the values accordingly?
image

vs.

image
  1. Features that exist but that you don't have local access to don't fail the entire command. This is probably ok but thought i'd highlight. I feel the most logical thing to do here is mirror what npm/yarn does?
image
  1. Features with a sha hash as the version are also ignored.
image

@chrmarti
Copy link
Contributor Author

chrmarti commented Jul 3, 2023

A couple questions:

  1. Features in my devcontainer.json without a version are omitted. Should we assume latest in this case and resolve the values accordingly?

Fixed.

  1. Features that exist but that you don't have local access to don't fail the entire command. This is probably ok but thought i'd highlight. I feel the most logical thing to do here is mirror what npm/yarn does?

I agree. Not sure actually what npm/yarn do (seems my setup doesn't work with GitHub package repo atm), but having some resilience towards missing credentials makes sense.

  1. Features with a sha hash as the version are also ignored.

Fixed.

Also adding an --output-format option with text being the default (following along the features info command).

@chrmarti chrmarti enabled auto-merge (squash) July 3, 2023 15:37
@chrmarti chrmarti merged commit ac767f1 into main Jul 3, 2023
@chrmarti chrmarti deleted the chrmarti/superb-porpoise branch July 3, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants