-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated command #565
Outdated command #565
Conversation
aa41157
to
3fa48c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one question, besides that looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions:
- Features in my
devcontainer.json
without aversion
are omitted. Should we assumelatest
in this case and resolve the values accordingly?
vs.
- Features that exist but that you don't have local access to don't fail the entire command. This is probably ok but thought i'd highlight. I feel the most logical thing to do here is mirror what npm/yarn does?
- Features with a sha hash as the version are also ignored.
Co-authored-by: Josh Spicer <[email protected]>
Fixed.
I agree. Not sure actually what npm/yarn do (seems my setup doesn't work with GitHub package repo atm), but having some resilience towards missing credentials makes sense.
Fixed. Also adding an |
Similar data to yarn's and NPM's outdated command. microsoft/vscode-remote-release#8640
E.g.: