-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows to package and release standalone binaries #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, create github release
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft so it isn't accidentally merged before #343.
This PR is a follow-up to #343 that updates the GHA workflows to build, test, and release the standalone binaries created by
@vercel/pkg
.Modifications to
dev-containers.yml
:Test
job when relevant files are modifiednode_modules
dirs between jobs/across CI runsCLI
job to build the standalone binaries on ubuntu-20.04,macos-11
, andwindows-2019
Test
job to run a subset of the tests on the standalone binaries (though can expand this to all tests if preferred!)See here for an example of a successful run.
Modifications to
publish-dev-containers.yml
:publish-dev-containers.yml
on branchesMake GitHub Release
andMake GitHub Draft Release
aren't selectedSee here for an example of a successful release on tag push, and here for the release it generated.
Notes on cross-compiling
ldid
) MacOS binaries from Ubuntu were unsuccessful--no-bytecode
, but the binaries failed tests on the target OS