Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle parsing variable expression in dockerfile #337

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

ShauryaAg
Copy link
Contributor

fixes: #336

@ShauryaAg ShauryaAg requested a review from a team as a code owner December 22, 2022 13:53
@ShauryaAg
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a few comments.

src/spec-node/dockerfileUtils.ts Show resolved Hide resolved
src/spec-node/dockerfileUtils.ts Outdated Show resolved Hide resolved
@ShauryaAg
Copy link
Contributor Author

Known issues:
The current implementation does not support quoted expression variables, that is ${arg:+"word"} will not be evaluated correctly in FROM statements as the fromStatement regex does not parse such FROM lines correctly.

cc: @chrmarti

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (Getting a second reviewer now before we can merge.)

@joshspicer joshspicer merged commit 338857f into devcontainers:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot recognise bash-style arguments in Dockerfile
3 participants