Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Chore ] Move server to .ts #240

Closed
wants to merge 4 commits into from

Conversation

kewinzaq1
Copy link

No description provided.

@@ -44,16 +44,16 @@ app.use((_, res, next) => {

app.use(
helmet({
referrerPolicy: { policy: 'same-origin' },
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the placement of these rules was incorrect

@kewinzaq1 kewinzaq1 force-pushed the chore/move-server-to-ts branch from 23d1e2e to 495f058 Compare May 12, 2024 13:24
@dev-xo
Copy link
Owner

dev-xo commented May 12, 2024

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

@dev-xo dev-xo changed the title chore: move server to ts [ Chore ] Move server to .ts May 12, 2024
@dev-xo dev-xo added the enhancement New feature or request label May 12, 2024
@dev-xo dev-xo self-requested a review May 12, 2024 15:53
@kewinzaq1
Copy link
Author

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

HI @dev-xo I did it based on The Epic Stack https://github.com/epicweb-dev/epic-stack

@kewinzaq1 kewinzaq1 force-pushed the chore/move-server-to-ts branch 2 times, most recently from 4f400ce to 34de560 Compare May 12, 2024 16:46
@kewinzaq1 kewinzaq1 force-pushed the chore/move-server-to-ts branch from 34de560 to bea693b Compare May 13, 2024 16:55
@dev-xo dev-xo marked this pull request as ready for review May 13, 2024 21:40
@dev-xo
Copy link
Owner

dev-xo commented May 13, 2024

This is about to be merged @kewinzaq1.

  • Do you know if any of these changes will impact deployment somehow? In case we should update something else.

@dev-xo
Copy link
Owner

dev-xo commented May 14, 2024

Made a first deployment attempt. Although everything seems to work as expected in terms of deployment, the server is not able to initialize the app, and not sure why, as the run command has not changed.

Will give it another try later, in order to recheck this.

  • Will also try to deploy the main repo without this PR's effects.

Moved execa to dependencies, instead of devDependencies (in a private repository), in the same way Epic Stack seems to have it configured.

  • After deployment, this still doesn't seem to work either.

Leaving this PR open, as probably someone else will be curious about it, and we can keep discussing it, looking for a fix or for ways to handle this.

@kewinzaq1
Copy link
Author

Made a first deployment attempt. Although everything seems to work as expected in terms of deployment, the server is not able to initialize the app, and not sure why, as the run command has not changed.

Will give it another try later, in order to recheck this.

  • Will also try to deploy the main repo without this PR's effects.

Moved execa to dependencies, instead of devDependencies (in a private repository), in the same way Epic Stack seems to have it configured.

  • After deployment, this still doesn't seem to work either.

Leaving this PR open, as probably someone else will be curious about it, and we can keep discussing it, looking for a fix or for ways to handle this.

Thanks for the information. I'll check this

@dev-xo dev-xo force-pushed the main branch 3 times, most recently from 58c696e to 0021b62 Compare June 28, 2024 22:20
@dev-xo dev-xo force-pushed the main branch 2 times, most recently from b7c9c89 to a18b4d8 Compare August 9, 2024 22:14
@dev-xo dev-xo closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants