-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Chore ] Move server to .ts #240
Conversation
@@ -44,16 +44,16 @@ app.use((_, res, next) => { | |||
|
|||
app.use( | |||
helmet({ | |||
referrerPolicy: { policy: 'same-origin' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the placement of these rules was incorrect
23d1e2e
to
495f058
Compare
Hello @kewinzaq1, I appreciate the efforts and the Pull Request. Could you explain where you got the references for the implementation, or the steps of it?
Solves: #232 |
HI @dev-xo I did it based on The Epic Stack https://github.com/epicweb-dev/epic-stack |
4f400ce
to
34de560
Compare
34de560
to
bea693b
Compare
This is about to be merged @kewinzaq1.
|
Made a first deployment attempt. Although everything seems to work as expected in terms of deployment, the server is not able to initialize the app, and not sure why, as the run command has not changed. Will give it another try later, in order to recheck this.
Moved
Leaving this PR open, as probably someone else will be curious about it, and we can keep discussing it, looking for a fix or for ways to handle this. |
Thanks for the information. I'll check this |
58c696e
to
0021b62
Compare
b7c9c89
to
a18b4d8
Compare
No description provided.