adjust the service for each os type and correct the control 10 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Münch <[email protected]>
chris-rock
reviewed
Mar 7, 2017
controls/postgres_spec.rb
Outdated
| it { should be_enabled } | ||
| end | ||
| when '16.04' | ||
| describe systemd_service(postgres.service) do |
There was a problem hiding this comment.
This may be related to inspec/inspec#931, similar things are reported to happen with debian
controls/postgres_spec.rb
Outdated
| describe processes('postgres') do | ||
| its('list.length') { should eq 1 } | ||
| end | ||
| elsif os[:family] == 'redhat' |
There was a problem hiding this comment.
Should we use os.redhat? and os.debian?
atomic111
changed the title
chris-rock
reviewed
Mar 8, 2017
controls/postgres_spec.rb
Outdated
| else | ||
| describe processes('postgres') do | ||
| its('list.length') { should eq 1 } | ||
| end |
There was a problem hiding this comment.
maybe:
if os.redhat? && os.release.include?('6')
pg_command = 'postmaster'
else
pg_command = 'postgres'
end
describe processes('postmaster') do
its('list.length') { should eq 1 }
end
There was a problem hiding this comment.
thanks for the input. i will do the changes
controls/postgres_spec.rb
Outdated
| describe command('/etc/init.d/postgresql status') do | ||
| its('stdout') { should include 'online' } | ||
| end | ||
| # describe upstart_service(postgres.service) do |
There was a problem hiding this comment.
lets remove those comments and keep the original test commented out, because that is where we want to go back to. InSpec should handle that properly.
atomic111
force-pushed
the
master
branch
3 times, most recently
from
2de5473
to
8bd8ddf
Compare
Signed-off-by: Patrick Münch <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Münch [email protected]