Removal of deprecated options for newer openssh versions #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Artem Sidorenko <[email protected]>
artem-sidorenko
force-pushed
the
deprecations
branch
from
3931dfd to
aec11f8
Compare
should not be used for openssh >=7.4 Signed-off-by: Artem Sidorenko <[email protected]>
for openssh >=7.5 Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Artem Sidorenko <[email protected]>
artem-sidorenko
force-pushed
the
deprecations
branch
from
aec11f8 to
c9e58c2
Compare
chris-rock
approved these changes
Oct 17, 2018
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Great improvement @artem-sidorenko
| @@ -0,0 +1,7 @@ | |||
| control 'sshd configuration should not have any deprecations' do | |||
Member
There was a problem hiding this comment.
Is that something we should also test in the baseline?
Member
Author
There was a problem hiding this comment.
I'm not sure about this: baseline and ssh-hardening can be used independently, maybe somebody still has or wants to have deprecated options for some reasons? In the same time I wanted to ensure our template here is always up-to-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Please see the dev-sec/ssh-baseline#114 and dev-sec/ssh-baseline#116 too