Skip to content

Conversation

@artem-sidorenko
Copy link
Member

Chef 13 is also using ruby 2.4.1 in the omnibus packages

There are problems with Chef 13.1 in the chefspec tests. The builds are getting stucked without any specific reason. I'll investigate this further...

Chef 13 is also using ruby 2.4.1 in the omnibus packages

Signed-off-by: Artem Sidorenko <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 50f3efa on ruby-2.4 into e2261fb on master.

@artem-sidorenko
Copy link
Member Author

@chris-rock @atomic111 can somebody please have a look here? I would like to make a new release when this is merged

Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem-sidorenko thanks for the great contribution

recipes/pam.rb Outdated

# configure tally2
if node['os-hardening']['auth']['retries'] > 0
if node['os-hardening']['auth']['retries'].positive?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know, why there is the error with the ubuntu 16.04 machine with chef 12.5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny thing, it looks like chef 12.5.1 was packaged with different ruby for ubuntu then to centos. I'll have a detailed look tomorrow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomic111 fixed. chef 12.5.1 has ruby 2.1 and not 2.3 (2.1 does not have positive?), I changed the rubocop settings to reflect that and also created dev-sec/chef-ssh-hardening#179

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomic111 thanks for catching this btw :-)

Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Artem Sidorenko <[email protected]>
@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8572c05 on ruby-2.4 into e2261fb on master.

@artem-sidorenko
Copy link
Member Author

artem-sidorenko commented Jun 9, 2017

something is broken with NYC2 DO region: its temporary disabled by DO completely. If it is not get fixed today I'll switch our tests to the NYC3 region

The default NYC2 seems to be disabled on DO and is not available
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling caba6d4 on ruby-2.4 into e2261fb on master.

@artem-sidorenko
Copy link
Member Author

@atomic111 fixed now (I switched the tests to the NYC3 region)

Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem-sidorenko thanks for the update. great job!!!

@atomic111 atomic111 merged commit 2d6edc0 into master Jun 12, 2017
@artem-sidorenko artem-sidorenko deleted the ruby-2.4 branch June 12, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants