-
Notifications
You must be signed in to change notification settings - Fork 133
CI: update to ruby 2.4.1 and gem update #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Chef 13 is also using ruby 2.4.1 in the omnibus packages Signed-off-by: Artem Sidorenko <[email protected]>
|
@chris-rock @atomic111 can somebody please have a look here? I would like to make a new release when this is merged |
atomic111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artem-sidorenko thanks for the great contribution
recipes/pam.rb
Outdated
|
|
||
| # configure tally2 | ||
| if node['os-hardening']['auth']['retries'] > 0 | ||
| if node['os-hardening']['auth']['retries'].positive? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know, why there is the error with the ubuntu 16.04 machine with chef 12.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny thing, it looks like chef 12.5.1 was packaged with different ruby for ubuntu then to centos. I'll have a detailed look tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomic111 fixed. chef 12.5.1 has ruby 2.1 and not 2.3 (2.1 does not have positive?), I changed the rubocop settings to reflect that and also created dev-sec/chef-ssh-hardening#179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomic111 thanks for catching this btw :-)
Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Artem Sidorenko <[email protected]>
|
something is broken with NYC2 DO region: its temporary disabled by DO completely. If it is not get fixed today I'll switch our tests to the NYC3 region |
The default NYC2 seems to be disabled on DO and is not available
|
@atomic111 fixed now (I switched the tests to the NYC3 region) |
atomic111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artem-sidorenko thanks for the update. great job!!!
Chef 13 is also using ruby 2.4.1 in the omnibus packages
There are problems with Chef 13.1 in the chefspec tests. The builds are getting stucked without any specific reason. I'll investigate this further...