[Refactor]: Opportunity Api calling methods #71
Conversation
| @@ -102,7 +102,12 @@ const Projects = { | |||
| } | |||
|
|
|||
| const Opportunities = { | |||
| list: () => requests.get<Opportunity[]>('opportunities'), | |||
| list: (params?: URLSearchParams) => requests.get<Opportunity[]>('opportunities', params), | |||
| post: (body: Opportunity) => requests.post<Opportunity>('opportunities', body), | |||
There was a problem hiding this comment.
'body: Opportunity' - Is this right approach to write?
There was a problem hiding this comment.
body is good, but to be more specific it should be opportunity
| @@ -102,7 +102,12 @@ const Projects = { | |||
| } | |||
|
|
|||
| const Opportunities = { | |||
| list: () => requests.get<Opportunity[]>('opportunities'), | |||
| list: (params?: URLSearchParams) => requests.get<Opportunity[]>('opportunities', params), | |||
| post: (body: Opportunity) => requests.post<Opportunity>('opportunities', body), | |||
There was a problem hiding this comment.
body is good, but to be more specific it should be opportunity
src/utils/agent.ts
Outdated
| list: () => requests.get<Opportunity[]>('opportunities'), | ||
| list: (params?: URLSearchParams) => requests.get<Opportunity[]>('opportunities', params), | ||
| post: (body: Opportunity) => requests.post<Opportunity>('opportunities', body), | ||
| getCount: () => requests.get<Object>('opportunities/count'), |
There was a problem hiding this comment.
I think we're going get number rather than Object
| list: (params?: URLSearchParams) => requests.get<Opportunity[]>('opportunities', params), | ||
| post: (body: Opportunity) => requests.post<Opportunity>('opportunities', body), | ||
| getCount: () => requests.get<Object>('opportunities/count'), | ||
| getDetails: (id: string) => requests.get<Opportunity>(`opportunities/${id}`), |
| post: (body: Opportunity) => requests.post<Opportunity>('opportunities', body), | ||
| getCount: () => requests.get<Object>('opportunities/count'), | ||
| getDetails: (id: string) => requests.get<Opportunity>(`opportunities/${id}`), | ||
| update: (id: string, body: Opportunity) => requests.put<Opportunity>(`opportunities/${id}`, body), |
There was a problem hiding this comment.
body is suppose to have all the interface properties set to optional because when send a put request to an api you only want to change specific fields and not everything.
check this out, maybe you'll learn something great with these utility types
https://www.typescriptlang.org/docs/handbook/utility-types.html#partialtype
| getCount: () => requests.get<Object>('opportunities/count'), | ||
| getDetails: (id: string) => requests.get<Opportunity>(`opportunities/${id}`), | ||
| update: (id: string, body: Opportunity) => requests.put<Opportunity>(`opportunities/${id}`, body), | ||
| delete: (id: string) => requests.delete<Object>(`opportunities/${id}`), |
There was a problem hiding this comment.
Hello @Enjoy2Live Thanks for the review. Had some confusions cause in api doc i got ->
id as string
and getCount api is returning object.
Should i still proceed?
There was a problem hiding this comment.
also the id is technically a number but it's not a huge deal if you keep it string
No description provided.