Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

日本語のリンター (textlint) 追加 #352

Merged
merged 50 commits into from
Sep 19, 2020
Merged

日本語のリンター (textlint) 追加 #352

merged 50 commits into from
Sep 19, 2020

Conversation

massongit
Copy link
Member

@massongit massongit commented Sep 10, 2020 •
edited
Loading

以下を追加します。

  • 日本語のチェックを行うCI (pr-textlint/lint, pr-textlint/format) 追加
  • yarnの更新を行うCI (pr-check-yarn) 追加
  • CIのsudden_deathへの反映を行うCI (pr-copy-ci-hato-bot) で反映される対象にtextlint関連のファイル追加

@massongit massongit marked this pull request as draft September 10, 2020 22:03
@github-actions github-actions bot mentioned this pull request Sep 10, 2020
Merged
@massongit
Merge pull request #353 from dev-hato/fix-text-add_textlint_3
ffaf11f 
日本語が間違ってたので直してあげたよ！PRをマージしてね！ #352
@massongit
Copy link
Member Author

massongit commented Sep 10, 2020 •
edited
Loading

jtf-style/4.3.1.丸かっこ（） は修正するときに片方のかっこしか直さないため、かっこの形式が統一されない状態になってしまう
したがって一旦除外

@massongit massongit marked this pull request as ready for review September 10, 2020 22:16
massongit
massongit commented Sep 13, 2020
View reviewed changes
massongit
massongit commented Sep 13, 2020
View reviewed changes
@massongit
Copy link
Member Author

massongit commented Sep 13, 2020 •
edited
Loading

textlint-rule-general-novel-style-ja の max_arabic_numeral_digits がIssue番号に適用されて書式が崩れる問題があるが、そもそもこのルール自体が技術文書にはそぐわない (桁数が多い数字を漢数字で表現することは少ない) ので、単純にルール自体を適用しないほうがシンプルで良さそう

@massongit
Copy link
Member Author

textlint-rule/textlint-rule-no-exclamation-question-mark#11 がマージされ、textlint-rule-no-exclamation-question-mark v1.1.0がリリースされたので、それを使用する形にした

@massongit massongit mentioned this pull request Sep 19, 2020
Closed
@github-actions
Copy link
Contributor

日本語のLint結果だよ！🕊🕊🕊

yarn run v1.22.5
$ /home/runner/work/hato-bot/hato-bot/node_modules/.bin/textlint ./CHANGELOG.md ./README.md ./doc/03_Deploy_to_Heroku.md ./doc/01_Get_Slack_API_Token.md ./doc/04_Setting_to_Event_URL.md ./doc/02_Get_Yahoo_API_Token.md
Done in 7.37s.

@github-actions
Copy link
Contributor

Lint結果だよ！🕊🕊🕊


------------------------------------
Your code has been rated at 10.00/10

@massongit massongit marked this pull request as ready for review September 19, 2020 10:15
@massongit massongit merged commit 1c00af4 into develop Sep 19, 2020
@massongit massongit deleted the add_textlint_3 branch September 19, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goryudyuma Goryudyuma Goryudyuma approved these changes

@bgpat bgpat Awaiting requested review from bgpat

Assignees
No one assigned
Labels
review please
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

日本語のlinterをCIに導入する
3 participants
@massongit @Goryudyuma @nakkaa